Skip to content

JsonDocument serialization breaking change #43883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gewarren merged 2 commits into from
Dec 9, 2024
Merged

JsonDocument serialization breaking change #43883

gewarren merged 2 commits into from
Dec 9, 2024

Conversation

@gewarren
Copy link
Contributor

@gewarren gewarren commented Dec 6, 2024 •
edited by github-actions bot
Loading

@gewarren gewarren requested a review from a team as a code owner December 6, 2024 00:34
@dotnetrepoman dotnetrepoman bot added this to the December 2024 milestone Dec 6, 2024
@gewarren gewarren requested review from Copilot and removed request for a team December 6, 2024 00:34
Copilot AI reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.

@gewarren gewarren requested review from a team and jeffhandley December 6, 2024 00:34
@gewarren gewarren enabled auto-merge (squash) December 6, 2024 00:35
BillWagner
BillWagner approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren gewarren merged commit 6000276 into dotnet:main Dec 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@BillWagner BillWagner BillWagner approved these changes

@jeffhandley jeffhandley Awaiting requested review from jeffhandley

Assignees

No one assigned

Labels

dotnet-fundamentals/svc

Projects

None yet

Milestone

December 2024

Development

Successfully merging this pull request may close these issues.

[Breaking change]: Nullable JsonDocument properties deserialize to JsonValueKind.Null instead of null

2 participants

@gewarren @BillWagner